Remove geosphere dependency
#236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to dev-rm-geosphere
|
Given that this function was really just a wrapper for geoshere::destPoint() that allows input in the form of compass point abbreviations (e.g., "NNE", "S"), I support this change and also suggest we deprecate this function in favor of a new function that simply converts the compass abbreviations to (nominal) numerical equivalents. Then suggest using geosphere::distPoint() with those as input. point_offset() is not used anywhere within this package, though I am aware of at least two people who use it to derive approximate location of snag line anchors (to facilitate receiver recovery). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current R CMD check failure is due to a floating point issue on macOS which will be fixed with acceptance of #228
This PR removes dependency on
geosphere(See #235).May introduce a breaking change in
point_offsetby using the Haversine (great circle) method as originally described in the documentation as opposed to a geodesic method (ellipsoid) as used bygeosphere. Creates differences on the order of <5 meters in distances less than a few dozen kilometers, but can increase to nearly 2 kilometers on the scale of the entire Great Lakes area.Adds initial tests for
point_offsetandinterpolate_pathas none currently exist.